Skip to content

Update csi-attacher and increase attacher timeout #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 14, 2025
Merged

Update csi-attacher and increase attacher timeout #396

merged 3 commits into from
Mar 14, 2025

Conversation

@Michkov
Copy link
Contributor

@Michkov Michkov commented Mar 13, 2025 •
edited
Loading

  • csi-attacher v4.8.1 is fixing multi-detach issues
  • setting timeout from default 15 seconds to 30 seconds since linode attach/detach operations are async and can take longer time

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@Michkov
Update csi-attacher and increase attacher timeout
5aa9abc 
- csi-attacher v4.8.1 is fixing multi-detach issues
- setting timeout from default 15 seconds to 30 seconds since linode
  attach/detach operations are async and can take longer time
@Michkov Michkov requested review from a team as code owners March 13, 2025 10:11
@codecov
Copy link

codecov bot commented Mar 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.98%. Comparing base (d228f4a) to head (b75f474).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #396   +/-   ##
=======================================
  Coverage   73.98%   73.98%           
=======================================
  Files          23       23           
  Lines        2725     2725           
=======================================
  Hits         2016     2016           
  Misses        578      578           
  Partials      131      131

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

guilhem
guilhem reviewed Mar 13, 2025
View reviewed changes
Copy link
Contributor

@guilhem guilhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guilhem
Copy link
Contributor

guilhem commented Mar 13, 2025

Issue for multiple detach:
kubernetes-csi/external-attacher#624

@komer3 komer3 added improvement for improvements in existing functionality in the changelog. changed labels Mar 13, 2025
@Michkov Michkov merged commit f496341 into main Mar 14, 2025
10 checks passed
@Michkov Michkov deleted the attacher-update branch March 14, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guilhem guilhem guilhem left review comments

@komer3 komer3 komer3 approved these changes

Assignees

No one assigned

Labels

improvement for improvements in existing functionality in the changelog.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Michkov @guilhem @komer3