Skip to content

Conversation

@Michkov
Copy link
Contributor

@Michkov Michkov commented Mar 13, 2025

Return linodeID of currently attached linode not the target.

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@Michkov Michkov marked this pull request as ready for review March 13, 2025 10:02
@Michkov Michkov requested review from a team as code owners March 13, 2025 10:02
Return linodeID of currently attached linode not the target.
@Michkov Michkov force-pushed the fix-already-attached-id branch from f1244ca to 125266b Compare March 13, 2025 10:16
@codecov
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.01%. Comparing base (ab7b9a8) to head (125266b).
Report is 17 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #395   +/-   ##
=======================================
  Coverage   73.01%   73.01%           
=======================================
  Files          23       23           
  Lines        2650     2650           
=======================================
  Hits         1935     1935           
  Misses        587      587           
  Partials      128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@guilhem guilhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@komer3 komer3 merged commit 5cafc6f into main Mar 13, 2025
8 checks passed
@komer3 komer3 deleted the fix-already-attached-id branch March 13, 2025 14:25
@komer3 komer3 added the bugfix for any bug fixes in the changelog. label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix for any bug fixes in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants