Skip to content

Conversation

@guilhem
Copy link
Contributor

@guilhem guilhem commented Mar 10, 2025

https://github.com/container-storage-interface/spec/blob/master/spec.md#controllerunpublishvolume

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@guilhem guilhem requested review from a team as code owners March 10, 2025 18:57
@guilhem guilhem force-pushed the unmountall branch 2 times, most recently from 0eeea9f to 745c221 Compare March 10, 2025 19:04
@codecov
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 83.87097% with 20 lines in your changes missing coverage. Please review.

Project coverage is 74.15%. Comparing base (d228f4a) to head (3f537bf).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
internal/driver/controllerserver.go 73.68% 8 Missing and 2 partials ⚠️
main.go 0.00% 4 Missing ⚠️
internal/driver/driver.go 75.00% 2 Missing ⚠️
internal/driver/nodeserver.go 88.23% 2 Missing ⚠️
pkg/logger/logger.go 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
+ Coverage   73.98%   74.15%   +0.17%     
==========================================
  Files          23       23              
  Lines        2725     2743      +18     
==========================================
+ Hits         2016     2034      +18     
  Misses        578      578              
  Partials      131      131              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@komer3 komer3 added the bugfix for any bug fixes in the changelog. label Mar 13, 2025
komer3
komer3 previously approved these changes Mar 13, 2025
Copy link
Contributor

@komer3 komer3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Glad we are adhering to the CSI Spec on detaching volume even if no node id is provided

@komer3 komer3 merged commit 0384567 into main Mar 18, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix for any bug fixes in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants