-
Couldn't load subscription status.
- Fork 63
unexpected node reboot #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #383 +/- ##
=======================================
Coverage 74.15% 74.15%
=======================================
Files 23 23
Lines 2743 2743
=======================================
Hits 2034 2034
Misses 578 578
Partials 131 131 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3f26503 to
ac299db
Compare
5b01d17 to
7652f16
Compare
| - sleep: | ||
| duration: 125s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a different option instead of using sleep here? I'm not a big fan of using sleep in test unless absolutely necessary. If there is a better dynamic option, lets use that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how to wait the good amount of time for timeout :/
I'm not even sure how to know this time if it's not default (50s)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a linode api we can ping to keep an eye on if the linode has booted back up? We could have some sort of exponential back of script that pings the api to check the status of the linode. If its booted up, then we proceed to the next step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about doubling the timeout for the wait step below this step?
5c701f3 to
16ba5bd
Compare
General:
Pull Request Guidelines: