Skip to content

Conversation

@guilhem
Copy link
Contributor

@guilhem guilhem commented Mar 8, 2025

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@codecov
Copy link

codecov bot commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.15%. Comparing base (0384567) to head (16ba5bd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #383   +/-   ##
=======================================
  Coverage   74.15%   74.15%           
=======================================
  Files          23       23           
  Lines        2743     2743           
=======================================
  Hits         2034     2034           
  Misses        578      578           
  Partials      131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@guilhem guilhem force-pushed the unexpectedreboot branch from 3f26503 to ac299db Compare March 8, 2025 16:00
@guilhem guilhem marked this pull request as ready for review March 8, 2025 16:48
@guilhem guilhem requested review from a team as code owners March 8, 2025 16:48
@komer3 komer3 added the testing for updates to the testing suite in the changelog. label Mar 10, 2025
@guilhem guilhem force-pushed the unexpectedreboot branch 3 times, most recently from 5b01d17 to 7652f16 Compare March 13, 2025 12:49
Comment on lines 117 to 118
- sleep:
duration: 125s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a different option instead of using sleep here? I'm not a big fan of using sleep in test unless absolutely necessary. If there is a better dynamic option, lets use that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to wait the good amount of time for timeout :/
I'm not even sure how to know this time if it's not default (50s)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a linode api we can ping to keep an eye on if the linode has booted back up? We could have some sort of exponential back of script that pings the api to check the status of the linode. If its booted up, then we proceed to the next step.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about doubling the timeout for the wait step below this step?

@komer3 komer3 merged commit c9f70f5 into main Mar 19, 2025
8 checks passed
@komer3 komer3 deleted the unexpectedreboot branch March 19, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing for updates to the testing suite in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants