Skip to content

Conversation

@komer3
Copy link
Contributor

@komer3 komer3 commented Feb 5, 2025

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@komer3 komer3 requested review from a team as code owners February 5, 2025 19:34
@codecov
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.11%. Comparing base (f577273) to head (da45100).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #366   +/-   ##
=======================================
  Coverage   73.11%   73.11%           
=======================================
  Files          23       23           
  Lines        2648     2648           
=======================================
  Hits         1936     1936           
  Misses        585      585           
  Partials      127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@komer3 komer3 changed the title [Test] Luks e2e test case for recreation and remounting [test] Luks e2e test case for recreation and remounting Feb 5, 2025
@komer3 komer3 added the testing for updates to the testing suite in the changelog. label Feb 5, 2025
Copy link
Contributor

@rahulait rahulait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@komer3 komer3 merged commit c60ef97 into main Feb 6, 2025
8 checks passed
@komer3 komer3 deleted the luks-e2e-remount branch February 6, 2025 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing for updates to the testing suite in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants