Skip to content

Conversation

@rahulait
Copy link
Contributor

@rahulait rahulait commented Jan 15, 2025

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

This PR removes the custom logic in CSI driver to parse the API URL. We now have UseURL method in linodego which does all the work of setting things correctly based on passed URL. This PR updates CSI driver to use that method instead of SetBaseURL.

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@rahulait rahulait requested review from a team as code owners January 15, 2025 03:35
@codecov
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.99%. Comparing base (7d96d22) to head (31dfd7b).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
- Coverage   73.23%   72.99%   -0.25%     
==========================================
  Files          23       23              
  Lines        2582     2559      -23     
==========================================
- Hits         1891     1868      -23     
  Misses        568      568              
  Partials      123      123              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rahulait rahulait requested a review from komer3 January 15, 2025 03:51
Copy link
Contributor

@komer3 komer3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rahulait rahulait merged commit eeae65f into main Jan 15, 2025
7 checks passed
@komer3 komer3 added the improvement for improvements in existing functionality in the changelog. label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement for improvements in existing functionality in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants