Skip to content

Metrics investigation for CSI driver and dashboard creation on Grafana #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Oct 9, 2024
Merged

Metrics investigation for CSI driver and dashboard creation on Grafana #274

Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
8387728
Added ports for the sidecars to allow prometheus to scrape the metrics
prajwalvathreya Sep 23, 2024
0c39d75
Fixed error in linode-csi-plugin container due to incorrect metrics port
prajwalvathreya Sep 23, 2024
68b9b98
Added documentation and example graphs for metrics in the csi-driver.
prajwalvathreya Sep 24, 2024
361c077
updated graphs and documentation.
prajwalvathreya Sep 25, 2024
0a4609e
added line break after future scope to keep the doc consistent
prajwalvathreya Sep 25, 2024
4df77e3
added additional node metrics
prajwalvathreya Sep 25, 2024
06d04b3
added clarification on the unit of measurement of time
prajwalvathreya Sep 25, 2024
fcf133b
fixed typo
prajwalvathreya Sep 25, 2024
aedc721
Moved metrics-documentation.md and example-images folder to the docs …
prajwalvathreya Sep 25, 2024
1db1a39
Merge branch 'refs/heads/main' into metrics-endpoint
prajwalvathreya Sep 26, 2024
28691b8
- Created make target for creating a grafana-dashboard
prajwalvathreya Sep 30, 2024
7f133cc
- created services to expose metrics to prometheus
prajwalvathreya Sep 30, 2024
cb43eff
- updated install script to run process in the background
prajwalvathreya Oct 1, 2024
4b09fbf
Merge branch 'main' into metrics-endpoint
prajwalvathreya Oct 1, 2024
c10ee59
- fixed conflict in Makefile
prajwalvathreya Oct 1, 2024
960c574
Update hack/install-monitoring-tools.sh
prajwalvathreya Oct 1, 2024
016edfa
Updated the syntax of passing the CLUSTER_NAME variable
prajwalvathreya Oct 1, 2024
efeea6e
Update hack/install-monitoring-tools.sh, namespace creation
prajwalvathreya Oct 1, 2024
9370d03
Update hack/install-monitoring-tools.sh Grafana helm chart update
prajwalvathreya Oct 1, 2024
5d92fbb
Update hack/install-monitoring-tools.sh Prometheus helm chart update
prajwalvathreya Oct 1, 2024
c0a1c56
- added environment variables for username, password, data retention …
prajwalvathreya Oct 1, 2024
069b55d
- removed echo used for debugging
prajwalvathreya Oct 1, 2024
802245f
Merge branch 'main' into metrics-endpoint
prajwalvathreya Oct 2, 2024
9bc3beb
- updated the script to 3 make targets
prajwalvathreya Oct 3, 2024
c120fa7
- updated templates to opt in to install using helm
prajwalvathreya Oct 4, 2024
3276b46
- fixed container port mapping which was causing containers to crash …
prajwalvathreya Oct 4, 2024
9e18c05
- resolving Makefile conflict
prajwalvathreya Oct 7, 2024
ceac735
Merge branch 'main' into metrics-endpoint
prajwalvathreya Oct 7, 2024
2977e89
- updated to helm chart to expose drivers based on passed flag `enabl…
prajwalvathreya Oct 7, 2024
9380f5d
- updated documentation to explain how to use the helm chart to enabl…
prajwalvathreya Oct 7, 2024
6fe3e49
Merge branch 'main' into metrics-endpoint
prajwalvathreya Oct 7, 2024
9d97d6e
- made changes to install metrics services through helm chart
prajwalvathreya Oct 8, 2024
79750ca
- reverted csi-driver image to latest
prajwalvathreya Oct 8, 2024
07c63df
- updated documentation to explain modifications to make targets
prajwalvathreya Oct 8, 2024
6ac52d6
- updated comment to a more sensible one
prajwalvathreya Oct 8, 2024
62e806d
- updated documentation to be less verbose
prajwalvathreya Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,3 +181,7 @@ release:
cp ./internal/driver/deploy/releases/linode-blockstorage-csi-driver-$(IMAGE_VERSION).yaml ./$(RELEASE_DIR)
sed -e 's/appVersion: "latest"/appVersion: "$(IMAGE_VERSION)"/g' ./helm-chart/csi-driver/Chart.yaml
tar -czvf ./$(RELEASE_DIR)/helm-chart-$(IMAGE_VERSION).tgz -C ./helm-chart/csi-driver .

.PHONY: grafana-dashboard
grafana-dashboard:
KUBECONFIG=test-cluster-kubeconfig.yaml NODE_NAME=$(CLUSTER_NAME) ./hack/install-monitoring-tools.sh --timeout=600s
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
- [Creating a Development Cluster](docs/development-setup.md#️-creating-a-development-cluster)
- [Running E2E Tests](docs/testing.md)
- [Contributing](docs/contributing.md)
- [Observability](docs/observability.md)
- [Metrics](docs/metrics-documentation.md)
- [License](#license)
- [Disclaimers](#-disclaimers)
- [Community](#-join-us-on-slack)
Expand Down
15 changes: 15 additions & 0 deletions deploy/kubernetes/base/ss-csi-linode-controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ spec:
- "--volume-name-uuid-length=16"
- "--csi-address=$(ADDRESS)"
- "--v=2"
- "--metrics-address=0.0.0.0:10248"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we potentially move all of the metrics related yaml updates to the helm chart on an opt in basis instead of here by default?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Evan. If we can do this, that would be a better approach.

ports:
- name: metrics
containerPort: 10248
protocol: TCP
env:
- name: ADDRESS
value: /var/lib/csi/sockets/pluginproxy/csi.sock
Expand All @@ -56,6 +61,11 @@ spec:
args:
- "--v=2"
- "--csi-address=$(ADDRESS)"
- "--metrics-address=0.0.0.0:10249"
ports:
- name: metrics
containerPort: 10249
protocol: TCP
env:
- name: ADDRESS
value: /var/lib/csi/sockets/pluginproxy/csi.sock
Expand All @@ -68,6 +78,11 @@ spec:
args:
- "--v=2"
- "--csi-address=$(ADDRESS)"
- "--metrics-address=0.0.0.0:10250"
ports:
- name: metrics
containerPort: 10250
protocol: TCP
env:
- name: ADDRESS
value: /var/lib/csi/sockets/pluginproxy/csi.sock
Expand Down
Loading
Loading