feat: fix team tekton-dashboard #2597
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR fixes access tekton dashboards for teams by adding a new istio sidecar that allows traffic to the kubernetes api cluster service.
The issue seems to present itself only on lke-e clusters which use cilim instead of calico. Normally the default sidecar CR in the team namespace should be enough to allow traffic to all Kubernetes Services in the cluster (e.g
*.svc.cluster.local) but on with cilium this seems to not work. By adding this sidecar Cr we explicitly allow traffic to the kube api and this seems to solve the issue.🔍 Reviewer Notes
🧹 Checklist