Skip to content

Conversation

@dennisvankekem
Copy link
Collaborator

Considerations

  • I have tested the changes in both light and dark mode.
  • I have considered the need for new unit tests.
  • I have tested the changes on a cluster.
  • I have included relevant documentation updates.
  • I have an approved Figma design or have reflected my changes in Figma
  • I have verified that the UI/UX is consistent in major browsers (e.g., Chrome, Firefox, Safari, Edge).
  • I have tested the changes for responsiveness in different screen resolutions.
  • I have tested expected error states and verified that the user is presented with informative error messages.
  • I have tested the feature with unusual or extreme inputs (e.g., very long strings, empty states, clicking a button multiple times quickly).

@dennisvankekem dennisvankekem requested review from ElderMatt, Copilot and ferruhcihan and removed request for ferruhcihan September 29, 2025 12:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the first phase of workloads functionality by refactoring existing workload pages and components. It introduces new workload-specific pages, updates API mutations to use APL-prefixed versions, and consolidates workload value handling into a unified approach.

  • Adds proper function names to anonymous workload page exports
  • Migrates to APL-specific workload mutations and removes separate values mutation
  • Refactors CodeEditor to handle both string and object inputs with improved type safety

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/pages/workloads/overview/WorkloadsOverviewPage.tsx Adds function name to anonymous export
src/pages/workloads/create-edit/WorkloadsCreateEditPage.tsx Updates to APL mutations and adds function name
src/pages/workloads/catalog/WorkloadCatalogsPage.tsx Adds function name to anonymous export
src/components/CodeEditor.tsx Refactors for better type safety and removes deprecated yaml library
src/components/Catalog.tsx Replaces WorkloadValues component with CodeEditor and restructures workload creation
src/App.tsx Updates routing to use new workload pages

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@ferruhcihan ferruhcihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dennisvankekem dennisvankekem merged commit 2a05759 into main Sep 30, 2025
6 checks passed
@dennisvankekem dennisvankekem deleted the APL-1154 branch September 30, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants