feat: validate values editor #428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-zimnowoda
previously requested changes
Aug 30, 2024
There was a problem hiding this comment.
It does not seem to work:
- I was able to remove all values from editor and it did not complain.
- I was able to add additional fields and it also did not complain
There if also a validate button that does not fit the styling. I do not think that this button is even needed.
Lastly it would be nice if you follow some standards about creating PRs.
- Most of our colleagues create a branch in apl-core where you can easily deploy changes. It is useful especially if changes require other PRs from other repos.
- This PR requires PR from apl-api but you have not indicated that.
- You have not invited anyone to PR review, why?
|
@j-zimnowoda this PR was supposed to be a draft PR but it seems that I didn't set it to draft, that is also the reason why I said it needs some work and why there is no reviewers or why it doesn't seem to fit the PR standards. |
ElderMatt
requested changes
Sep 13, 2024
…i-console into dvk-validate-values-editor
ElderMatt
requested changes
Sep 16, 2024
ElderMatt
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
does need some work as the red lines appear only on line 1, didn't manage to get a solution in time,
monaco-yamlseemed like a promised solution but required ejecting react and tinker with web pack which is a no go. If someone knows an elegant solution please let me know. Otherwise I'll try to finish it up next monday