Skip to content

Add back windows workflow testing #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 19, 2025
Merged

Add back windows workflow testing #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
32f0243
Test over all Python, enable windows
amc-corey-cox May 14, 2025
f97fa57
Just test 3.9 until this is working
amc-corey-cox May 14, 2025
ae2f2ea
Should have done 3.10
amc-corey-cox May 14, 2025
6c51471
Try updating linkml-runtime
amc-corey-cox May 14, 2025
d9a1fe4
Change to only affect windows
amc-corey-cox May 14, 2025
479df58
Look at failing tests
amc-corey-cox May 14, 2025
e1aaf7f
Test classes and slots directly, not len
amc-corey-cox May 14, 2025
d632cb0
Remove the monkey patch
amc-corey-cox May 14, 2025
2823d6e
Going back to the monkey patch
amc-corey-cox May 14, 2025
f99c7ed
Remove unnecessary assertions
amc-corey-cox May 14, 2025
3809678
A better monkey patch?
amc-corey-cox May 14, 2025
69d44f9
Another 'safer' monkey patch
amc-corey-cox May 14, 2025
50d5f69
Add back all versions testing
amc-corey-cox May 14, 2025
83d8cf1
Merge branch 'main' into fix_win_164
amc-corey-cox May 16, 2025
f1ba269
Merge branch 'main' into fix_win_164
ptgolden May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/check-pull-request.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,8 @@ jobs:
strategy:
fail-fast: false
matrix:
# os: [ ubuntu-latest, windows-latest ] - Exclude windows for now
os: [ ubuntu-latest ]
os: [ ubuntu-latest, windows-latest ]
python-version: [ "3.9", "3.10", "3.11", "3.12" , "3.13" ]
Copy link
Preview

Copilot AI May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] There’s an extra space before the comma between "3.12" and "3.13"; removing it will improve YAML readability.

Suggested change
python-version: [ "3.9", "3.10", "3.11", "3.12" , "3.13" ]
python-version: [ "3.9", "3.10", "3.11", "3.12", "3.13" ]

Copilot uses AI. Check for mistakes.

exclude:
- os: windows-latest
python-version: "3.9"

runs-on: ${{ matrix.os }}

Expand Down
Loading