Skip to content

[server][dvc] Add configurable client-side transfer timeout #1859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025

Conversation

jingy-li
Copy link
Contributor

Problem Statement

In this PR: #1805, we removed the client-side timeout and relied solely on the server-side timeout. However, in the DVC use case, we observed scenarios where the client never receives any response—neither success nor failure—from certain hosts, resulting endless bootstrap.

One such case is: the client sends a request to the server, the server receives it, generates the snapshot, and begins the transfer. However, immediately afterward, the server host starts bootstrapping, which interrupts the transfer process entirely. The client, unaware of this interruption, continues waiting indefinitely for a response.

Solution

Therefore, this PR reintroduces the client-side timeout logic and makes the timeout duration configurable.

Code changes

  • Added new code behind a config. If so list the config names and their default values in the PR description.
  • Introduced new log lines.
    • Confirmed if logs need to be rate limited to avoid excessive logging.

Concurrency-Specific Checks

Both reviewer and PR author to verify

  • Code has no race conditions or thread safety issues.
  • Proper synchronization mechanisms (e.g., synchronized, RWLock) are used where needed.
  • No blocking calls inside critical sections that could lead to deadlocks or performance degradation.
  • Verified thread-safe collections are used (e.g., ConcurrentHashMap, CopyOnWriteArrayList).
  • Validated proper exception handling in multi-threaded code to avoid silent thread termination.

How was this PR tested?

  • New unit tests added.
  • New integration tests added.
  • Modified or extended existing tests.
  • Verified backward compatibility (if applicable).

Does this PR introduce any user-facing or breaking changes?

  • No. You can skip the rest of this section.
  • Yes. Clearly explain the behavior change and its impact.

Copy link
Contributor

@gaojieliu gaojieliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@jingy-li jingy-li merged commit 00cf017 into linkedin:main Jun 10, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants