[server][dvc] Add configurable client-side transfer timeout #1859
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
In this PR: #1805, we removed the client-side timeout and relied solely on the server-side timeout. However, in the DVC use case, we observed scenarios where the client never receives any response—neither success nor failure—from certain hosts, resulting endless bootstrap.
One such case is: the client sends a request to the server, the server receives it, generates the snapshot, and begins the transfer. However, immediately afterward, the server host starts bootstrapping, which interrupts the transfer process entirely. The client, unaware of this interruption, continues waiting indefinitely for a response.
Solution
Therefore, this PR reintroduces the client-side timeout logic and makes the timeout duration configurable.
Code changes
Concurrency-Specific Checks
Both reviewer and PR author to verify
synchronized
,RWLock
) are used where needed.ConcurrentHashMap
,CopyOnWriteArrayList
).How was this PR tested?
Does this PR introduce any user-facing or breaking changes?