-
Notifications
You must be signed in to change notification settings - Fork 97
[client][test] Add OTel key count metric #1791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add key_count metrics in OTel.
4f3602c
to
4053da5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lluwm. Leaving some nit comments until we decide on the major changes.
.../venice-client/src/main/java/com/linkedin/venice/fastclient/StatsAvroGenericStoreClient.java
Outdated
Show resolved
Hide resolved
.../venice-client/src/main/java/com/linkedin/venice/fastclient/StatsAvroGenericStoreClient.java
Outdated
Show resolved
Hide resolved
...ient/src/test/java/com/linkedin/venice/fastclient/DispatchingAvroGenericStoreClientTest.java
Outdated
Show resolved
Hide resolved
...da-vinci-client/src/main/java/com/linkedin/davinci/client/StatsAvroGenericDaVinciClient.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating. Left some comments.
...da-vinci-client/src/main/java/com/linkedin/davinci/client/StatsAvroGenericDaVinciClient.java
Outdated
Show resolved
Hide resolved
...nal/venice-client-common/src/main/java/com/linkedin/venice/stats/dimensions/MessageType.java
Show resolved
Hide resolved
clients/venice-thin-client/src/main/java/com/linkedin/venice/client/stats/BasicClientStats.java
Outdated
Show resolved
Hide resolved
.../venice-thin-client/src/test/java/com/linkedin/venice/client/stats/BasicClientStatsTest.java
Show resolved
Hide resolved
...lient-common/src/main/java/com/linkedin/venice/stats/dimensions/VeniceMetricsDimensions.java
Show resolved
Hide resolved
internal/venice-client-common/src/test/java/com/linkedin/venice/stats/ClientTypeTest.java
Show resolved
Hide resolved
clients/venice-thin-client/src/main/java/com/linkedin/venice/client/stats/BasicClientStats.java
Outdated
Show resolved
Hide resolved
clients/venice-thin-client/src/main/java/com/linkedin/venice/client/stats/BasicClientStats.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. Left One minor comment.
clients/venice-thin-client/src/main/java/com/linkedin/venice/client/stats/BasicClientStats.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lluwm
Problem Statement
Add
key_count
metrics in OTel for all clients.Solution
This change adds the following OTel metrics:
The existing tehuti metric e.g.
success_request_key_count
metric will still be emitted along with thekey_count
metrics in OTel.Code changes
Concurrency-Specific Checks
Both reviewer and PR author to verify
synchronized
,RWLock
) are used where needed.ConcurrentHashMap
,CopyOnWriteArrayList
).How was this PR tested?
Does this PR introduce any user-facing or breaking changes?