[controller] admin tool command to clean execution IDs #1730
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
We store the successful execution IDs for each store in ZK path //executionIds/succeededPerStore. This is like a checkpoint till what point we have successfully processed the admin messages for each store.
But when we delete a store, we do not clean this map. This can result into the size of this ZNode grow beyond the allowed limit of 1MB.
At this point, no admin messages can be updated into this, hence cannot be consumed, for ANY store in that cluster.
Solution
This admin tool command will remove the entries for the deleted stores and help to reduce the size of this ZNode.
However, still it can reach to the max size and hence puts a limit to how many stores we can have in a venice cluster. Also note that there is a limit to how many children a ZNode can have (100K) which also limits the number of venice stores in a cluster.
Code changes
Concurrency-Specific Checks
Both reviewer and PR author to verify
synchronized
,RWLock
) are used where needed.ConcurrentHashMap
,CopyOnWriteArrayList
).How was this PR tested?
Does this PR introduce any user-facing or breaking changes?