Skip to content

Add comment for webhook parser #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 3, 2025
Merged

Add comment for webhook parser #437

merged 4 commits into from
Apr 3, 2025

Conversation

Yang-33
Copy link
Contributor

@Yang-33 Yang-33 commented Apr 2, 2025

No description provided.

@Yang-33 Yang-33 requested a review from a team April 2, 2025 00:14
@Yang-33 Yang-33 self-assigned this Apr 2, 2025
@Yang-33 Yang-33 removed the request for review from a team April 2, 2025 00:17
@Yang-33 Yang-33 marked this pull request as draft April 2, 2025 00:17
@Yang-33
Copy link
Contributor Author

Yang-33 commented Apr 2, 2025 

E, [2025-04-02T00:15:05.123489 #1969] ERROR -- rbs: sig/line/bot/v2/webhook_parser.rbs:13:38...13:50: Could not find ::OpenStruct (RBS::NoTypeFoundError)

            ) -> Array[Webhook::Event | ::OpenStruct]
                                        ^^^^^^^^^^^^

checking ...

@Yang-33 Yang-33 force-pushed the comment-for-webhook-parser branch from 59f3149 to 7a02341 Compare April 3, 2025 02:05
@Yang-33
Copy link
Contributor Author

Yang-33 commented Apr 3, 2025

#453 dropped OpenStruct, thanks

@Yang-33 Yang-33 marked this pull request as ready for review April 3, 2025 05:36
@Yang-33 Yang-33 requested a review from a team April 3, 2025 05:36
@Yang-33 Yang-33 merged commit 88957ae into line:master Apr 3, 2025
6 checks passed
@Yang-33 Yang-33 deleted the comment-for-webhook-parser branch April 3, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mokuzon mokuzon mokuzon approved these changes

Assignees

@Yang-33 Yang-33

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Yang-33 @mokuzon