Reintroduce Timing-Safe Signature Verification in v2 Webhook Parser #435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #428
In v1, we had a constant-time signature comparison to mitigate timing attacks.
line-bot-sdk-ruby/lib/line/bot/v1/client.rb
Lines 1654 to 1691 in a6db291
In v2(before release), this check was removed. This patch reintroduces timing-safe verification, ensuring that the request body and the
x-line-signature
header are validated without leaking timing information.