Skip to content

Conversation

Yang-33
Copy link
Contributor

@Yang-33 Yang-33 commented Apr 1, 2025

There is no issue with some variables conflicting, but not to confuse me, this change renames them.

for example, conflict is happened here:

def set_rich_menu_image_with_http_info(
rich_menu_id:,
body: nil
)
path = "/v2/bot/richmenu/{richMenuId}/content"
.gsub(/{richMenuId}/, rich_menu_id)
response = @http_client.post(
path: path,
body_params: body,
)
body = case response.code.to_i
when 200
response.body
else
response.body
end
[body, response.code.to_i, response.each_header.to_h]
end
# Upload rich menu image
#
# @param rich_menu_id The ID of the rich menu to attach the image to
# @param body
# @see https://developers.line.biz/en/reference/messaging-api/#upload-rich-menu-image
def set_rich_menu_image(
rich_menu_id:,
body: nil
)
body, _status_code, _headers = set_rich_menu_image_with_http_info(
rich_menu_id: rich_menu_id,
body: body
)
body

@Yang-33 Yang-33 marked this pull request as ready for review April 1, 2025 09:47
@Yang-33 Yang-33 requested a review from a team April 1, 2025 09:47
@Yang-33 Yang-33 self-assigned this Apr 1, 2025
Copy link
Contributor

@mokuzon mokuzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@Yang-33 Yang-33 merged commit eb50ad6 into line:master Apr 2, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants