Automate publish #339
Merged
Automate publish #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yang-33
commented
Nov 14, 2024
Comment on lines
+26
to
+35
| - name: Update version file with the release version | ||
| run: | | ||
| if [ "${{ github.event_name }}" == "workflow_dispatch" ]; then | ||
| VERSION=${{ github.event.inputs.version }} | ||
| else | ||
| VERSION=${{ github.event.release.tag_name }} | ||
| fi | ||
| VERSION=${VERSION#v} | ||
|
|
||
| sed -i "s/VERSION = \".*\"/VERSION = \"$VERSION\"/" lib/line/bot/api/version.rb |
There was a problem hiding this comment.
This step is to avoid editing file to update version manually (
)
mokuzon
approved these changes
Nov 15, 2024
|
Though I added 0ae7daf after running this workflow, it worked~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Resolve #299
Rubygems provides a way to release gem with GitHub Actions officially. It seems it doesn't require personal access token. let's try to use it.
On publishing, this workflow calls
bundle exec rake release, and it tries to push git tag. this doesn't match our use case. We always create release note with git tag in this repository at first (in other 5 bot sdk projects), and we want the workflow to publish(release) gem later.This change modifies
releasetask not to push git tag. I don't know if this works. Let me try it.ref:
publish.ymlinline/line-bot-sdk-rubycan be trusted inline-bot-apigem: https://rubygems.org/gems/line-bot-api/trusted_publishers