Skip to content

Bump luzer with sanitizers support #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bump luzer with sanitizers support #133

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1b889f
cmake: replace string with env as a list
ligurio May 30, 2025
9fc045c
cmake: support ASAN/UBSan in lapi tests
ligurio May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tests/lapi/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,13 @@ lapi_tests_make_lua_path(LUA_PATH
${CMAKE_CURRENT_SOURCE_DIR}/?.lua
)

list(APPEND TEST_ENV
"LUA_PATH=${LUA_PATH};"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: I suppose there is no need for ; here and below, since it is already the list.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LUA_PATH and LUA_CPATH are not touched in proposed patch, however, I've fixed for LD_PRELOAD_LIBS:

@@ -29,7 +33,7 @@ list(APPEND TEST_ENV
   "LUA_CPATH=${LUA_CPATH};"
   "ASAN_OPTIONS=detect_odr_violation=0;"
   "LD_DYNAMIC_WEAK=1;"
-  "LD_PRELOAD=${LD_PRELOAD_LIBS};"
+  "LD_PRELOAD=${LD_PRELOAD_LIBS}"
 )
 
 function(create_test)

"LUA_CPATH=${LUA_CPATH};"
"ASAN_OPTIONS=detect_odr_violation=0;"
"LD_DYNAMIC_WEAK=1;"
)

function(create_test)
cmake_parse_arguments(
FUZZ
Expand Down Expand Up @@ -45,7 +52,7 @@ function(create_test)
)
set_tests_properties(${test_name} PROPERTIES
LABELS "lapi"
ENVIRONMENT "LUA_PATH=${LUA_PATH};LUA_CPATH=${LUA_CPATH};ASAN_OPTIONS=detect_odr_violation=0;LD_DYNAMIC_WEAK=1"
ENVIRONMENT "${TEST_ENV}"
DEPENDS ${LUA_EXECUTABLE} ${LUZER_LIBRARY}
)
endfunction()
Expand Down