-
Couldn't load subscription status.
- Fork 138
Full asset burn #1791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full asset burn #1791
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is generally heading towards the right direction
Take a look at our dev guidelines for further info around styling & git commit structure that we generally follow.
Also the linked issue seems to be referring to this as if the only we need is removing the stop gap for the full burn. I was under the impression that the stop gap was there for a protocol-level limitation related to having a simple vOutput burning all of the input amounts. cc @Roasbeef
66b0443 to
ccc5d1f
Compare
ccc5d1f to
3cddf81
Compare
3cddf81 to
49e56b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a release note that describes the updates in docs/release-notes/release-notes-0.7.0.md with a link to this PR
(this will fix the failing CI step)
Otherwise, looks good!
2799109 to
def7337
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The litd itest failures appear to be unrelated. LGTM! 👍
def7337 to
85a8ac5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very close
85a8ac5 to
869a7cf
Compare
869a7cf to
4a75419
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Enable burn of full asset of anchor output (Fixes #1435, Fixes #918)
The goal of the PR is to enable "full burns" where all the asset units anchored to a UTXO are destroyed.
amount_to_burnequals the full UTXO amount and no other assets are present.This PR doesn't address issue #514, zero-value outputs accumulate and are not garbage collected.