Skip to content

Conversation

@darioAnongba
Copy link
Contributor

@darioAnongba darioAnongba commented Sep 11, 2025

Enable burn of full asset of anchor output (Fixes #1435, Fixes #918)

The goal of the PR is to enable "full burns" where all the asset units anchored to a UTXO are destroyed.

  • Remove stop gap when the amount_to_burn equals the full UTXO amount and no other assets are present.
  • The burn goes to a unique provably unspendable key.
  • Ensures the burn proof is generated correctly.

This PR doesn't address issue #514, zero-value outputs accumulate and are not garbage collected.

@darioAnongba darioAnongba self-assigned this Sep 11, 2025
@levmi levmi moved this from 🆕 New to 🏗 In progress in Taproot-Assets Project Board Sep 11, 2025
@GeorgeTsagk GeorgeTsagk self-requested a review September 12, 2025 10:43
Copy link
Member

@GeorgeTsagk GeorgeTsagk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is generally heading towards the right direction

Take a look at our dev guidelines for further info around styling & git commit structure that we generally follow.

Also the linked issue seems to be referring to this as if the only we need is removing the stop gap for the full burn. I was under the impression that the stop gap was there for a protocol-level limitation related to having a simple vOutput burning all of the input amounts. cc @Roasbeef

@darioAnongba darioAnongba changed the title tapfreighter: full asset burn Full asset burn Sep 16, 2025
@lightninglabs lightninglabs deleted a comment from coveralls Sep 16, 2025
@darioAnongba darioAnongba marked this pull request as ready for review September 17, 2025 17:58
@darioAnongba darioAnongba moved this from 🏗 In progress to 👀 In review in Taproot-Assets Project Board Sep 19, 2025
Copy link
Member

@GeorgeTsagk GeorgeTsagk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a release note that describes the updates in docs/release-notes/release-notes-0.7.0.md with a link to this PR
(this will fix the failing CI step)

Otherwise, looks good!

Copy link
Member

@jtobin jtobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The litd itest failures appear to be unrelated. LGTM! 👍

@levmi levmi added this to the v0.8 milestone Sep 25, 2025
@darioAnongba darioAnongba removed the request for review from Roasbeef September 25, 2025 15:59
Copy link
Member

@GeorgeTsagk GeorgeTsagk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very close

Copy link
Member

@GeorgeTsagk GeorgeTsagk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@GeorgeTsagk GeorgeTsagk added this pull request to the merge queue Sep 30, 2025
Merged via the queue into main with commit 6d104fd Sep 30, 2025
37 of 38 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Taproot-Assets Project Board Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

[feature]: Burn All Assets of Anchor Output [bug]: Asset Burning for Collectibles

6 participants