sweepbatcher: batch change outputs #976
Draft
+303
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optional change of a swap is encoded in its sweeps as a pointer to the same change output. This change is taken into account when constructing the unsigned batch transaction when it comes to tx weight and outputs.
Presigning sweeps takes change outputs into account. Each sweep belonging to the same sweep group points to the same change output, if existent. sweepbatcher.presign scans all passed sweeps for change outputs and passes them to constructUnsignedTx.
The batcher now presigns sweep groups including an optional change output. Change is usually leftover from the client's swap amount which is returned to the client.
hieblmi
force-pushed
the
batcher-change-outputs
branch
from
19b13cd to
c7091de
Compare
hieblmi
commented
Jul 9, 2025
| for _, sweep := range sweeps { | ||
| // If the sweep has a change output, add it to the changeOutputs | ||
| // map to avoid duplicates. | ||
| if sweep.change != nil { |
There was a problem hiding this comment.
flatten depth by if == nil { continue }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The batcher receives the ability to sign and publish batches with change outputs.
Change is created when the clients choose fractional swap amounts from the input values to be swapped. Usually the change is sent back to client's addresses.
If change is provided to
ensurePresigned,presignandpublishPresigned, it is expected to be placed within the passed[]sweep.Each
sweepoptionally holds a pointer to a change output. Multiple sweeps holding the same change reference will produce a single change output in the batch transaction.