swapserverrpc: arbitrary static swap amount #951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieblmi
force-pushed
the
swap-amount-rpcs
branch
3 times, most recently
from
f87ec32 to
947d08b
Compare
starius
approved these changes
Jun 19, 2025
swapserverrpc/staticaddr.proto
Outdated
| server will take out this amount from the total value of provided | ||
| deposit_outpoints and will send the change back to the static address. If | ||
| not specified the server will use the total amount of the deposit_outpoints | ||
| as swap amount. |
There was a problem hiding this comment.
What happens, if the amount is too close to the total amount (so the change would be dust)? I think it makes sense if it fails and suggests to remove the flag to use the whole amount.
Could you add the actual expected behavior in this case to the comment, please?
Also, if the amount is equal to the total amount, it makes sense just to succeed, right? And if higher - fail.
There was a problem hiding this comment.
I expanded the comment to explain.
Note, there is no flag to use the whole amount of provided deposits for backwards compatibility. If deposits are specified without an amount the whole amount is used.
hieblmi
force-pushed
the
swap-amount-rpcs
branch
4 times, most recently
from
72e88de to
d023b0c
Compare
|
Rebased master |
Optional change of a swap is encoded in its sweeps as a pointer to the same change output. This change is taken into account when constructing the unsigned batch transaction when it comes to tx weight and outputs.
Presigning sweeps takes change outputs into account. Each sweep belonging to the same sweep group points to the same change output, if existent. sweepbatcher.presign scans all passed sweeps for change outputs and passes them to constructUnsignedTx.
The batcher now presigns sweep groups including an optional change output. Change is usually leftover from the client's swap amount which is returned to the client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
amountfield to theServerStaticAddressLoopInRequest.