Skip to content

staticaddr: fix logs, use %v not %w in logs #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

staticaddr: fix logs, use %v not %w in logs #941

merged 1 commit into from
May 13, 2025
+4 −4

Conversation

starius
Copy link
Collaborator

@starius starius commented May 13, 2025

Fix log lines like this:

[ERR] SADDR fsm.go:457: Deposit xxx:1: unable to update deposit: %!w(*errors.errorString=&{sql: database is closed})

Pull Request Checklist

  • Update release_notes.md if your PR contains major features, breaking changes or bugfixes

@starius starius requested review from bhandras and hieblmi May 13, 2025 14:51
hieblmi
hieblmi approved these changes May 13, 2025
View reviewed changes
Copy link
Collaborator

@hieblmi hieblmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM.

sputn1ck
sputn1ck approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@sputn1ck sputn1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@starius starius marked this pull request as ready for review May 13, 2025 15:03
@starius starius merged commit 890b91c into lightninglabs:master May 13, 2025
4 checks passed
@starius starius deleted the fix-log-w branch May 13, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhandras bhandras bhandras approved these changes

@sputn1ck sputn1ck sputn1ck approved these changes

@hieblmi hieblmi hieblmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@starius @bhandras @sputn1ck @hieblmi