dev.Dockerfile: allow forcing a taprpc version #1116
Conversation
We can now use the `TAPRPC_VERSION` build argument to force a specific taprpc version to be used when building. If the `TAPRPC_VERSION` build argument is not set, then build continues as before this change and uses the version already defined in `go.mod` and `go.sum`.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ZZiigguurraatt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the dev.Dockerfile by introducing a new build argument, TAPRPC_VERSION, which provides developers with the flexibility to explicitly control the taprpc dependency version during the Docker image build process. This is particularly useful for testing specific taprpc versions or ensuring compatibility, while maintaining the existing default behavior if no version is specified.
Highlights
- New Docker Build Argument: Introduced
TAPRPC_VERSIONas a new build argument indev.Dockerfile. This allows users to specify a particulartaprpcversion when building the Docker image. - Conditional Dependency Management: Added logic within
dev.Dockerfileto conditionally fetch and use thetaprpcdependency at the version specified by theTAPRPC_VERSIONbuild argument. If the argument is not set, the build proceeds using the version defined ingo.modandgo.sum.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a new build argument TAPRPC_VERSION to the development Dockerfile, allowing for a specific version of taprpc to be used during the build. The implementation is consistent with the existing mechanism for overriding other dependencies like lnd and taproot-assets.
My main feedback is on the build efficiency. The current pattern of running go mod tidy after each go get is suboptimal. I've left a comment suggesting a refactor to improve build times by running go mod tidy only once.
Overall, the change is correct and achieves its goal.
| && if [ -n "$TAPRPC_VERSION" ]; then \ | ||
| go get -v github.com/lightninglabs/taproot-assets/taprpc@$TAPRPC_VERSION \ | ||
| && go mod tidy; \ | ||
| fi \ |
There was a problem hiding this comment.
While this change is consistent with the existing pattern for overriding dependencies, the pattern of running go mod tidy after each go get is inefficient as it can run up to three times. This increases the build time.
A more efficient approach would be to run all the go get commands first, and then run go mod tidy a single time at the end if any of the version arguments were provided.
This could be addressed in a follow-up PR to refactor this part of the Dockerfile for better build performance.
There was a problem hiding this comment.
i don't like that because it requires more if statements and I don't think go mod tidy runs that long
We can now use the
TAPRPC_VERSIONbuild argument to force a specific taprpc version to be used when building. If theTAPRPC_VERSIONbuild argument is not set, then build continues as before this change and uses the version already defined ingo.modandgo.sum.