mobx: update types in the mobx stores

Author: jamaljsr

app/src/store/stores/accountStore.ts

@@ -8,6 +8,7 @@ import {
   values,
 } from 'mobx';
 import { AccountState } from 'types/generated/trader_pb';
+import Big from 'big.js';
 import copyToClipboard from 'copy-to-clipboard';
 import debounce from 'lodash/debounce';
 import { hex } from 'util/strings';
@@ -86,7 +87,7 @@ export default class AccountStore {
    * @param amount the amount (sats) to fund the account with
    * @param expiryBlocks the number of blocks from now to expire the account
    */
-  async createAccount(amount: number, expiryBlocks: number, confTarget?: number) {
+  async createAccount(amount: Big, expiryBlocks: number, confTarget?: number) {
     this._store.log.info(`creating new account with ${amount}sats`);
     try {
       const acct = await this._store.api.pool.initAccount(
@@ -142,7 +143,7 @@ export default class AccountStore {
       const res = await this._store.api.pool.renewAccount(
         acct.traderKey,
         expiryBlocks,
-        feeRate,
+        Big(feeRate),
       );
       runInAction(() => {
         // the account should always be defined but if not, fetch all accounts as a fallback
@@ -214,7 +215,11 @@ export default class AccountStore {
       const acct = this.activeAccount;
       this._store.log.info(`depositing ${amount}sats into account ${acct.traderKey}`);
 
-      const res = await this._store.api.pool.deposit(acct.traderKey, amount, feeRate);
+      const res = await this._store.api.pool.deposit(
+        acct.traderKey,
+        Big(amount),
+        feeRate,
+      );
       runInAction(() => {
         // the account should always be defined but if not, fetch all accounts as a fallback
         if (res.account) {
@@ -238,7 +243,11 @@ export default class AccountStore {
       const acct = this.activeAccount;
       this._store.log.info(`withdrawing ${amount}sats into account ${acct.traderKey}`);
 
-      const res = await this._store.api.pool.withdraw(acct.traderKey, amount, feeRate);
+      const res = await this._store.api.pool.withdraw(
+        acct.traderKey,
+        Big(amount),
+        feeRate,
+      );
       runInAction(() => {
         if (res.account) {
           acct.update(res.account);

app/src/store/stores/batchStore.ts

@@ -9,6 +9,7 @@ import {
 } from 'mobx';
 import { NodeTier } from 'types/generated/auctioneerrpc/auctioneer_pb';
 import { LeaseDuration } from 'types/state';
+import Big from 'big.js';
 import { IS_DEV, IS_TEST } from 'config';
 import debounce from 'lodash/debounce';
 import { hex } from 'util/strings';
@@ -35,7 +36,7 @@ export default class BatchStore {
   markets: ObservableMap<LeaseDuration, Market> = observable.map();
 
   /** the timestamp of the next batch in seconds */
-  nextBatchTimestamp = 0;
+  nextBatchTimestamp = Big(0);
 
   /** the fee rate (sats/vbyte) estimated by the auctioneer to use for the next batch */
   nextFeeRate = 0;
@@ -166,12 +167,12 @@ export default class BatchStore {
     try {
       const res = await this._store.api.pool.nextBatchInfo();
       runInAction(() => {
-        this.setNextBatchTimestamp(res.clearTimestamp);
+        this.setNextBatchTimestamp(Big(res.clearTimestamp));
         this._store.log.info(
           'updated batchStore.nextBatchTimestamp',
           this.nextBatchTimestamp,
         );
-        this.setNextFeeRate(res.feeRateSatPerKw);
+        this.setNextFeeRate(Big(res.feeRateSatPerKw));
         this._store.log.info('updated batchStore.nextFeeRate', this.nextFeeRate);
       });
     } catch (error) {
@@ -254,15 +255,15 @@ export default class BatchStore {
    * batched to be processed
    * @param timestamp the next batch timestamp in seconds since epoch
    */
-  setNextBatchTimestamp(timestamp: number) {
+  setNextBatchTimestamp(timestamp: Big) {
     // if the value is the same, then just return immediately
-    if (this.nextBatchTimestamp === timestamp) return;
+    if (this.nextBatchTimestamp.eq(timestamp)) return;
 
     this.nextBatchTimestamp = timestamp;
 
     if (this._nextBatchTimer) clearTimeout(this._nextBatchTimer);
     // calc the number of ms between now and the next batch timestamp
-    let ms = timestamp * 1000 - Date.now();
+    let ms = timestamp.mul(1000).sub(Date.now()).toNumber();
     // if the timestamp is somehow in the past, use 10 mins as a default
     if (ms < 0) ms = 10 * 60 * 1000;
     this._nextBatchTimer = setTimeout(this.fetchLatestBatch, ms + 3000);
@@ -271,9 +272,9 @@ export default class BatchStore {
   /**
    * sets the nextFeeRate by converting the provided sats/kw to sats/vbyte
    */
-  setNextFeeRate(satsPerKWeight: number) {
+  setNextFeeRate(satsPerKWeight: Big) {
     const satsPerVbyte = this._store.api.pool.satsPerKWeightToVByte(satsPerKWeight);
-    this.nextFeeRate = Math.ceil(satsPerVbyte);
+    this.nextFeeRate = satsPerVbyte.round(0, Big.roundUp).toNumber();
   }
 
   startPolling() {

app/src/store/stores/channelStore.ts

@@ -240,7 +240,7 @@ export default class ChannelStore {
           const localPubkey = this._store.nodeStore.pubkey;
           const policy = node1Pub === localPubkey ? node2Policy : node1Policy;
           if (policy) {
-            acc[channelId] = policy.feeRateMilliMsat;
+            acc[channelId] = +Big(policy.feeRateMilliMsat);
           }
           return acc;
         }, data);

app/src/store/stores/orderStore.ts

@@ -174,7 +174,7 @@ export default class OrderStore {
    * @param maxBatchFeeRate the maximum batch fee rate to allowed as sats per vByte
    */
   async quoteOrder(
-    amount: number,
+    amount: Big,
     rateFixed: number,
     duration: number,
     minUnitsMatch: number,
@@ -202,9 +202,9 @@ export default class OrderStore {
       return {
         ratePerBlock: rateFixed,
         ratePercent: 0,
-        totalExecutionFeeSat: 0,
-        totalPremiumSat: 0,
-        worstCaseChainFeeSat: 0,
+        totalExecutionFeeSat: '0',
+        totalPremiumSat: '0',
+        worstCaseChainFeeSat: '0',
       };
     }
   }
@@ -221,7 +221,7 @@ export default class OrderStore {
    */
   async submitOrder(
     type: OrderType,
-    amount: number,
+    amount: Big,
     rateFixed: number,
     duration: number,
     minUnitsMatch: number,