mobx: update types in the mobx models

Author: jamaljsr

app/src/store/models/batch.ts

@@ -48,7 +48,7 @@ export default class Batch {
   prevBatchId = '';
   clearingPriceRate = 0;
   batchTxId = '';
-  batchTxFeeRateSatPerKw = 0;
+  batchTxFeeRateSatPerKw = Big(0);
   matchedOrders: MatchedOrder[] = [];
 
   // the provided lease duration to filter orders by
@@ -101,21 +101,21 @@ export default class Batch {
   /** the total amount of sats earned in this batch */
   get earnedSats() {
     const pctRate = this._store.api.pool.calcPctRate(
-      this.clearingPriceRate,
-      this.leaseDuration,
+      Big(this.clearingPriceRate),
+      Big(this.leaseDuration),
     );
     return this.volume.mul(pctRate);
   }
 
   /** the fee in sats/vbyte rounded to the nearest whole number */
   get feeLabel() {
-    return `${Math.round(this.feeInVBytes)}`;
+    return this.feeInVBytes.round().toString();
   }
 
   /** a label containing the batch fee in both sats/kw and sats/vbyte */
   get feeDescription() {
     // round the fee to 2 decimal places
-    const fee = Math.round(this.feeInVBytes * 100) / 100;
+    const fee = this.feeInVBytes.mul(100).round().div(100);
     return `${this.batchTxFeeRateSatPerKw} sats/kw - ${fee} sats/vbyte`;
   }
 
@@ -145,8 +145,8 @@ export default class Batch {
   /** the batch clearing rate expressed as basis points */
   get basisPoints() {
     const pct = this._store.api.pool.calcPctRate(
-      this.clearingPriceRate,
-      this.leaseDuration,
+      Big(this.clearingPriceRate),
+      Big(this.leaseDuration),
     );
     // convert the percentage to basis points. round up to prevent 0 bps
     // which is the case for the first batch on testnet which has a
@@ -173,7 +173,7 @@ export default class Batch {
     this.batchId = hex(llmBatch.batchId);
     this.prevBatchId = hex(llmBatch.prevBatchId);
     this.batchTxId = llmBatch.batchTxId;
-    this.batchTxFeeRateSatPerKw = llmBatch.batchTxFeeRateSatPerKw;
+    this.batchTxFeeRateSatPerKw = Big(llmBatch.batchTxFeeRateSatPerKw);
     // loop over all markets to limit the orders of this batch to a specific lease duration
     llmBatch.matchedMarketsMap.forEach(([duration, market]) => {
       // ignore markets for other lease durations

app/src/store/models/lease.ts

@@ -15,8 +15,8 @@ export default class Lease {
   premiumSat = Big(0);
   executionFeeSat = Big(0);
   chainFeeSat = Big(0);
-  clearingRatePrice = 0;
-  orderFixedRate = 0;
+  clearingRatePrice = Big(0);
+  orderFixedRate = Big(0);
   orderNonce = '';
   purchased = false;
   channelRemoteNodeKey = '';
@@ -45,8 +45,8 @@ export default class Lease {
     this.premiumSat = Big(poolLease.premiumSat);
     this.executionFeeSat = Big(poolLease.executionFeeSat);
     this.chainFeeSat = Big(poolLease.chainFeeSat);
-    this.clearingRatePrice = poolLease.clearingRatePrice;
-    this.orderFixedRate = poolLease.orderFixedRate;
+    this.clearingRatePrice = Big(poolLease.clearingRatePrice);
+    this.orderFixedRate = Big(poolLease.orderFixedRate);
     this.orderNonce = hex(poolLease.orderNonce);
     this.purchased = poolLease.purchased;
     this.channelRemoteNodeKey = hex(poolLease.channelRemoteNodeKey);

app/src/store/models/order.ts

@@ -27,17 +27,17 @@ export default class Order {
   traderKey = '';
   amount = Big(0);
   state = 0;
-  rateFixed = 0;
-  maxBatchFeeRateSatPerKw = 0;
+  rateFixed = Big(0);
+  maxBatchFeeRateSatPerKw = Big(0);
   units = 0;
   unitsUnfulfilled = 0;
   reserved = Big(0);
-  creationTimestamp = 0;
+  creationTimestamp = Big(0);
   minNodeTier?: Tier = 0;
   // custom app values
   type: OrderType = OrderType.Bid;
   // for bids, this is the minimum. for asks this is the maximum
-  duration = 0;
+  duration = Big(0);
 
   constructor(store: Store) {
     makeAutoObservable(this, {}, { deep: false, autoBind: true });
@@ -102,7 +102,7 @@ export default class Order {
 
   /** The date this swap was created as a JS Date object */
   get createdOn() {
-    return new Date(this.creationTimestamp / 1000 / 1000);
+    return new Date(this.creationTimestamp.div(1000).div(1000).toNumber());
   }
 
   /** The date this swap was created as formatted string */
@@ -124,15 +124,15 @@ export default class Order {
     this.traderKey = hex(poolOrder.traderKey);
     this.amount = Big(poolOrder.amt);
     this.state = poolOrder.state;
-    this.rateFixed = poolOrder.rateFixed;
-    this.maxBatchFeeRateSatPerKw = poolOrder.maxBatchFeeRateSatPerKw;
+    this.rateFixed = Big(poolOrder.rateFixed);
+    this.maxBatchFeeRateSatPerKw = Big(poolOrder.maxBatchFeeRateSatPerKw);
     this.units = poolOrder.units;
     this.unitsUnfulfilled = poolOrder.unitsUnfulfilled;
     this.reserved = Big(poolOrder.reservedValueSat);
-    this.creationTimestamp = poolOrder.creationTimestampNs;
+    this.creationTimestamp = Big(poolOrder.creationTimestampNs);
 
     this.type = type;
-    this.duration = duration;
+    this.duration = Big(duration);
     this.minNodeTier = minNodeTier;
   }
 
@@ -149,16 +149,16 @@ export default class Order {
       case 'type':
         return a.type.toLowerCase() > b.type.toLowerCase() ? 1 : -1;
       case 'amount':
-        return +a.amount.sub(b.amount);
+        return a.amount.sub(b.amount).toNumber();
       case 'rateFixed':
-        return a.rateFixed - b.rateFixed;
+        return a.rateFixed.sub(b.rateFixed).toNumber();
       case 'duration':
-        return a.duration - b.duration;
+        return a.duration.sub(b.duration).toNumber();
       case 'stateLabel':
         return a.stateLabel.toLowerCase() > b.stateLabel.toLowerCase() ? 1 : -1;
       case 'creationTimestamp':
       default:
-        return a.creationTimestamp - b.creationTimestamp;
+        return a.creationTimestamp.sub(b.creationTimestamp).toNumber();
     }
   }
 }

app/src/store/models/swap.ts

@@ -12,8 +12,8 @@ export default class Swap {
   id = '';
   type = 0;
   amount = Big(0);
-  initiationTime = 0;
-  lastUpdateTime = 0;
+  initiationTime = Big(0);
+  lastUpdateTime = Big(0);
   state = 0;
   failureReason = 0;
 
@@ -107,7 +107,7 @@ export default class Swap {
 
   /** The date this swap was created as a JS Date object */
   get createdOn() {
-    return new Date(this.initiationTime / 1000 / 1000);
+    return new Date(this.initiationTime.div(1000).div(1000).toNumber());
   }
 
   /** The date this swap was created as formatted string */
@@ -117,7 +117,7 @@ export default class Swap {
 
   /** The date this swap was last updated as a JS Date object */
   get updatedOn() {
-    return new Date(this.lastUpdateTime / 1000 / 1000);
+    return new Date(this.lastUpdateTime.div(1000).div(1000).toNumber());
   }
 
   /** The date this swap was last updated as formatted string */
@@ -133,8 +133,8 @@ export default class Swap {
     this.id = loopSwap.id;
     this.type = loopSwap.type;
     this.amount = Big(loopSwap.amt);
-    this.initiationTime = loopSwap.initiationTime;
-    this.lastUpdateTime = loopSwap.lastUpdateTime;
+    this.initiationTime = Big(loopSwap.initiationTime);
+    this.lastUpdateTime = Big(loopSwap.lastUpdateTime);
     this.state = loopSwap.state;
     this.failureReason = loopSwap.failureReason;
   }
@@ -154,12 +154,12 @@ export default class Swap {
       case 'typeName':
         return a.typeName.toLowerCase() > b.typeName.toLowerCase() ? 1 : -1;
       case 'amount':
-        return +a.amount.sub(b.amount);
+        return a.amount.sub(b.amount).toNumber();
       case 'initiationTime':
-        return a.initiationTime - b.initiationTime;
+        return a.initiationTime.sub(b.initiationTime).toNumber();
       case 'lastUpdateTime':
       default:
-        return a.lastUpdateTime - b.lastUpdateTime;
+        return a.lastUpdateTime.sub(b.lastUpdateTime).toNumber();
     }
   }