Skip to content

nhooyr.io/websocket -> github.com/coder/websocket #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

starius
Copy link
Contributor

@starius starius commented Jun 10, 2025

nhooyr.io/websocket is now deprecated. The author proposed to use github.com/coder/websocket: https://github.com/nhooyr/websocket-old/releases

Also, version nhooyr.io/websocket@v1.8.7 was removed from GitHub, so the build was failing with GOPROXY=direct. Proxy https://proxy.golang.org still has nhooyr.io/websocket@v1.8.7 in its cache.

lightning-node-connect/mailbox$ GOPROXY=direct go install go: downloading nhooyr.io/websocket v1.8.7
client_transport.go:9:2: reading nhooyr.io/websocket/go.mod at revision v1.8.7: unknown revision v1.8.7

nhooyr.io/websocket is now deprecated. The author proposed to use
github.com/coder/websocket: https://github.com/nhooyr/websocket-old/releases

Also, version nhooyr.io/websocket@v1.8.7 was removed from GitHub, so
the build was failing with GOPROXY=direct. Proxy https://proxy.golang.org
still has nhooyr.io/websocket@v1.8.7 in its cache.

lightning-node-connect/mailbox$ GOPROXY=direct go install
go: downloading nhooyr.io/websocket v1.8.7
client_transport.go:9:2: reading nhooyr.io/websocket/go.mod at revision v1.8.7: unknown revision v1.8.7
@starius starius merged commit 2f1d46e into lightninglabs:master Jun 10, 2025
5 checks passed
@starius starius deleted the migrate-websocket branch June 10, 2025 18:23
starius added a commit to starius/aperture that referenced this pull request Jun 10, 2025
Include lightninglabs/lightning-node-connect#116
It replaced a deprecated and removed dependency (nhooyr.io/websocket) with
an updated version.

Fix building with GOPROXY=direct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants