-
Notifications
You must be signed in to change notification settings - Fork 63
aperture: internally aggregate session statistics to reduce cardinality #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aperture: internally aggregate session statistics to reduce cardinality #172
Conversation
e43f56a
to
9fc2af7
Compare
Pushing a lint fix. |
@djkazic, remember to re-request review from reviewers when ready |
9fc2af7
to
7233c25
Compare
Force pushed some changes around TTL and formatting / comments. PTAL @Roasbeef |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ❄️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this.
Were you able to test this with the LNC test page?
Would perhaps make sense to make sure the numbers will be what we expect. Maybe @ViktorTigerstrom has time to do a test run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK, LGTM 🎉
This PR adds aggregation and classification of sessions into
{active, standby, inuse}
categories and makes direct metrics exportable.It is an attempt to lower the cardinality of the prior used read count metric. This should greatly reduce the load on Prometheus for both storage and querying.
However, there is a caveat with the code as-is: