Trivial #3752 followups #3848
Open
Trivial #3752 followups #3848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for assigning @tnull as a reviewer! |
joostjager
previously approved these changes
Jun 12, 2025
|
Perhaps you want to do this one too #3752 (comment) |
tnull
previously approved these changes
Jun 12, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3848 +/- ##
==========================================
- Coverage 89.93% 89.91% -0.02%
==========================================
Files 163 163
Lines 131276 131278 +2
Branches 131276 131278 +2
==========================================
- Hits 118062 118043 -19
- Misses 10529 10545 +16
- Partials 2685 2690 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Did it in #3851 |
Because LDK generally relies on traits passed via `Deref`, its tempting to just wrap implementations in `Arc` even when we don't otherwise need access to the implementation later. This does result in an unnecessary allocation, which is one-time and not a huge deal but irritates my OCD substantially. Here we drop the unnecessary `Arc` indirections in favor of simply implementing `Deref` directly on the sync wrappers used in `bump_transaction`.
TheBlueMatt
force-pushed
the
2025-06-3752-clones
branch
from
5f7a934 to
2fc13d1
Compare
|
Oops, squash-pushed a rustfmt fix. |
Pretty thorough work |
joostjager
approved these changes
Jun 12, 2025
tnull
reviewed
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just remove some unnecessary clones