Skip to content

LSPS2: Add support for ongoing proportional fees #3846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

aylagreystone
Copy link

Adds support for ongoing proportional fee proposal for bLIP52 lightning/blips#63

Still waiting for more feedback on the bLIP change but having it implemented in at least one implementation seems to be a requirement for merge so preparing one for LDK.

@ldk-reviews-bot
Copy link

👋 Hi! I see this is a draft PR.
I'll wait to assign reviewers until you mark it as ready for review.
Just convert it out of draft status when you're ready for review!

Copy link

codecov bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.82%. Comparing base (b8673f3) to head (0045de2).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3846      +/-   ##
==========================================
- Coverage   89.88%   89.82%   -0.06%     
==========================================
  Files         162      162              
  Lines      130415   130420       +5     
  Branches   130415   130420       +5     
==========================================
- Hits       117217   117145      -72     
- Misses      10509    10576      +67     
- Partials     2689     2699      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants