Add some trivial logging during RGS update processing. #2147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
force-pushed
the
2023-04-rgs-log-some
branch
2 times, most recently
from
a7e074b to
ebea48a
Compare
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2147 +/- ##
==========================================
- Coverage 91.35% 91.33% -0.02%
==========================================
Files 102 102
Lines 49909 49915 +6
Branches 49909 49915 +6
==========================================
- Hits 45592 45590 -2
- Misses 4317 4325 +8
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Rather than being totally silent, we need to at least note that we are processing an RGS update when doing so in the logs, which we do here. Fixes lightningdevkit#1981.
TheBlueMatt
force-pushed
the
2023-04-rgs-log-some
branch
from
ebea48a to
6897e5c
Compare
valentinewallace
approved these changes
Apr 4, 2023
wpaulino
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than being totally silent, we need to at least note that we are processing an RGS update when doing so in the logs, which we do here.
Fixes #1981.