Add is_running function to Node
#169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbesraa
commented
Sep 27, 2023
src/lib.rs
Outdated
| @@ -708,6 +708,11 @@ impl<K: KVStore + Sync + Send + 'static> Node<K> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| /// Checks if [`Node`] runtime is available. | |||
There was a problem hiding this comment.
indentation is a bit off, will fix it.
anything else I should mention in the comment?
because this check is more "codey" check and not really has anything to do with the network, should we mention this?
There was a problem hiding this comment.
Thanks! Seems fine, although we could maybe just make it "Returns whether the [Node] is running." (as mentioning the runtime feels a bit like we're leaking internals that the user doesn't need to care about).
jbesraa
force-pushed
the
feat/is-node-running
branch
from
0570a96 to
0212d21
Compare
tnull
reviewed
Sep 28, 2023
- Expose in bindings
jbesraa
force-pushed
the
feat/is-node-running
branch
from
0212d21 to
0a95d72
Compare
|
looks like we need to pin some crate(s) here? |
Yeah, fixed that in #151. |
tnull
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #164