Scroll to selected chapter #18497
Scroll to selected chapter #18497
Conversation
| const activeChapter = (v: VNode) => { | ||
| const kids = (v.children as any[]) ?? []; | ||
| const activeVnode = kids.find(c => c?.data?.class?.active); | ||
| return activeVnode?.elm as HTMLElement | undefined; |
There was a problem hiding this comment.
the source of truth is ctrl.currentChapter(), not the DOM. The DOM is for presentation only, not storage/retrieval of information.
| const dyTop = t.top - c.top; | ||
| const dyBottom = t.bottom - c.bottom; | ||
| if (dyTop < 0) el.scrollTop += dyTop; | ||
| else if (dyBottom > 0) el.scrollTop += dyBottom; |
There was a problem hiding this comment.
isn't this reinventing scrollToInnerSelector that we see in use in this same file?
https://github.com/lichess-org/lila/blob/master/ui/analyse/src/study/studyChapters.ts#L177-L177
There was a problem hiding this comment.
@ornicar Yeah I was approaching this the wrong way. Updated so that any adjustments needed for scrolling take place in view where it first happens.
|
it looks like the file already contains code that tries to scroll the the selected chapter: https://github.com/lichess-org/lila/blob/master/ui/analyse/src/study/studyChapters.ts#L175-L178 Let's fix it instead of adding more code alongside it to achieve the same thing. |
johndoknjas
force-pushed
the
scroll-to-selected-chapter
branch
from
595328b to
f08d656
Compare
2 participants
Makes it so that a scroll is done to the active chapter, in the event of a chapter change or page load.
Recording of current behaviour:
Screen.Recording.2025-10-26.at.11.09.35.PM.mov
After this patch:
Screen.Recording.2025-10-26.at.11.11.11.PM.mov
EDIT: after recent commits, same as recording except will scroll so that a previously obscured chapter is in the middle of the viewable section (when this is possible).