-
-
Couldn't load subscription status.
- Fork 2.5k
Translation support for module "practice" #17969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
9bb5440 to
366d663
Compare
|
@superuser-does any idea when was the last time we edited/added a new practice study? we've got the names and descriptions of these defined in mod practice UI and stored in mongo, and now with this PR there's a hard coded mapping of, effectively, the entire en-GB destination strings back to translation xml keys, which are then mapped by scalatags to the right language. it's not ideal, and it breaks as soon as a mod edits practice. i guess the thing to do is use translation xml keys here: ? |
|
@schlawg greetings! Please, give me advices on how can be right translation implemented differ way: where should be stored translation for Generally, I think this should implemented for 3 steps(PR's):
Additionally en-GB language code, which you are noticed, is currently seems absent in lila, am I right understand you? We don't have to be afraid hardcode currently, because I can manually maintain all changes for this module and operatively send you PR's on updates, while I will doing implementation based on DB translation mechanisms. And will do that for enough long time. |
|
lila-db-seed is just spam data. the real practice config text is stored in a monogodb collection on our production infrastructure. it's nothing wrong that you did, this is our problem to solve before practice can be translated. |
|
@schlawg oh, if I can be somehow helpful, just contact me directly in discord PM or email: |
|
I left a more detailed comment in our internal discussion, and will reiterate it here for visibility.
The last real edits to the copy were in 2024, with minor adjustments in January 2025. There remains some feedback in #14219 that requires a decision. The decision to effectively freeze the strings should follow some final adjustments to Practice. We should consider doing a phased release. In a phased approach, we'd first determine which parts of the course we are happy with. They should represent well-written content with an appropriate learning curve. After that, let's make only the OK parts translateable. This will be a good impetus to actually complete the course. There have often been ideas about expanding it out, and setting a vision for what the Practice course should be, will give us an idea of when a module can be considered 'final'. For example, we may be looking to make a complete one-volume guide to the game, akin to the Mammoth Book of Chess by Graham Burgess. In summary, here is what I'd suggest:
|
remove the configuration page and hardcode the entire practice structure it's inevitable if we translate it with crowdin - I think
string "Broaden your knowledge"
instead of duplicating the structure with translation maps there's a lot more to do!
doesn't compile but I gotta switch to something else
these files can only be created and updated by and through crowdin
|
Well this is our last chance to improve the wording: Many of these sentences are rather lame. That's because I wrote them, rather quickly, while building the feature, a long time ago. Anyone wants to improve them before they're sent to mass translation? You can do it right from your browser by going to https://github.com/shprotru/lila/edit/i17097_practice/translation/source/practice.xml?pr=/lichess-org/lila/pull/17969 |

Next step for #17097
This is initial support for translation for module "practice".
preview: