Delete earlier moves#12986 WIP

[ross39]

I would like to get some feedback on adding a new button delete earlier moves #12986. It currently works(I think :) ) but the problem is that when used outside the analysis board, when the moves are deleted and you go to create the study from the game, the side view shows the supposed to be deleted moves. Any ideas on why this happens? I thought maybe it was a socket issue so I modified analyse/socket.ts but that did not fix the issue. Thanks

[lenguyenthanh]

This will required changes in lila-ws (for support new socket command) and lila backend for update study to database.

[ross39]

pushing what I have done so far. I am confused on one thing as I am trying to figure out how deleteNode works as its quite similar to delete earlier moves just instead of deleting from the current node down the tree I am trying to delete from the current node to the parent(root).

I have a question. If I open a recently played game and click 'Delete From Here' and then add the game to the study why does the full pgn still appear in the study?. To make my question more clear

1. Go to recently played game (https://lichess.org/baz6CzB0/black)
2. Click 'Delete From Here' on any move. This correctly deletes the moves from the view
3. Click menu and then click study and add the game to a study
4. The view shows the supposed to be deleted moves.

The reason I ask this is because 'Delete Earlier Moves' deletes the moves in the view but the moves are still there when I create a study from the game as described above.

[ljh-serius]

Congrats !

[6heads]

What's the current status of your pr? I'm also missing the feature to delete previous moves.