[Connection callback] Update to fresh Master branch #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of recently, `macos-latest` runner switched to macOS-14-arm64 host, and Coverity (at least currently available image) only works on Intel/x86_64-based systems. `macos-latest-large` macOS runner is Intel-based, as per documentation.
Apparently `macos-latest-large` is only available for payed accounts.
`hid_send_output_report` sends report over control pipe, unlike existing `hid_write` which would send the data on the first interrupt OUT endpoint, if one exists and only falls back to control pipe.
- fix name of the function on macOS - add compile-time check by the CI Fixes: libusb#683
libusb#681) This warning shows up when building with libusb support using MSVC. Upstreaming of libsdl-org/SDL@1664ac4
…orkflows (libusb#691) As recommended by @dependabot.
- to match recently updated download-artifact (v3 is incompatible with v4); - actions/upload-artifact@v3 is scheduled for deprecation on November 30, 2024;
…usb#697) According to documentation, the system reserves the right to run WriteFile synchronously, even if FILE_FLAG_OVERLAPPED is set, so `bytes_written` needs to be taken from `WriteFile` directly in that case.
Add API function to control hid_write timeout on WinAPI backend. Resolves: libusb#686
…ssible for devices without ReportID) (libusb#707) -Add reconstruction logic of const padding bytes at the end of a report for devices which don't use ReportIDs -Enhanced padding logic to distinguish between byte and bit padding. -Add a new test case for Razer Cobra mouse `1532_00A3_0002_0001` which has a completly con feature report of 90 bytes. -Modified expected report descriptor reference file `045E_02FF_0005_0001_expected.rpt_desc` to include additional padding bytes.
Found by Coverity
Fix compilation with older WINVER.
As it used to be with autotools. Fixes: libusb#622
Fix build with latest GithubActions.
hid_read_error is a separate error function, that returns error status of hid_read/hid_read_timeout. hid_read/hid_read_timeout is no longer changes internal buffer used by hid_error and it makes it safe to use hid_read/hid_read_timeout from a separa thread, concurently with other device functions.
Based on libusb#696 - Add missing checks for zero/null arguments; - Better management of error strings in case of failures; --------- Co-authored-by: Megamouse <studienricky89@googlemail.com>
|
It's probably better to rebase instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just merging in
master.Did check that Windows builds still compile just fine, did not run any tests.
Did not check other systems.