Skip to content

Convert from KnuthBendix and a word type to a Presentation. #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: v1
Choose a base branch
from

Conversation

Joseph-Edwards
Copy link
Collaborator

This PR consists of a minor refactor of the to function that removes unnecessary lambdas, and adds the option to convert a KnuthBendix object to a Presentation over words with a specified type.

@Joseph-Edwards
Copy link
Collaborator Author

This will fail until libsemigroups/731 is merged into stable-3.0, and stable-3.0 is merged into main.

Copy link
Member

@james-d-mitchell james-d-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks @Joseph-Edwards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants