Skip to content

Use conda version of libsemigroups in the CI #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: v1
Choose a base branch
from

Conversation

Joseph-Edwards
Copy link
Collaborator

This PR updates the CI to use the conda version of libsemigroups, and also adds a job that uses the main version of libsemigroups.

@Joseph-Edwards Joseph-Edwards force-pushed the ci-use-conda branch 3 times, most recently from 46ce2ea to 53d427b Compare April 30, 2025 23:42
@Joseph-Edwards Joseph-Edwards force-pushed the ci-use-conda branch 2 times, most recently from 9bcf0b2 to 8104c37 Compare May 1, 2025 13:12
@Joseph-Edwards
Copy link
Collaborator Author

This now seems to be working as expected (passing on the main branch, failing when running the doctest in the conda version). For an example of the action that uses a specific fork and branch of libsemigroups, see this example on my fork.

@Joseph-Edwards Joseph-Edwards marked this pull request as ready for review May 1, 2025 14:31
Copy link
Member

@james-d-mitchell james-d-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, should we maybe hold off merging this until we’ve released a new version of libsemigroups?

@Joseph-Edwards
Copy link
Collaborator Author

Looks good to me, should we maybe hold off merging this until we’ve released a new version of libsemigroups?

Yeah that seems sensible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants