- 
                Notifications
    You must be signed in to change notification settings 
- Fork 38
implemented libdns NS/TXT/CName/Address types #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
these are the types that do not require further parsing
| pardon the force pushes | 
| Seems setting is working, but checking is not. Bizarre. Weirder still is that it was failing to look up the host by name (this log is by ID), which is presumably causing the check failure. @mholt was the ZONE api changed in 1.0? | 
| @theAeon Do you mean like the  | 
| Yeah, that one. Wonder if thats a bug internal to the plugin. I suppose its worth testing w/ 2.9/released version | 
| It could definitely be a bug in the dynamic-dns plugin. 🤷♂️ (Sorry I've been a bit too busy to look into it!) | 
| 
 no worries-"update every time despite failing checks" is still functional! | 
| Maybe we could also bump the libdns dependency to v1.1.0 while we're at it? | 
| would rec. just doing it after merging the pr tbh | 
| While working on #289 I fixed several things - including proper libdns types. I think that PR provides stronger coverage support overall. I acknowledge you were ahead of me here - it wasn’t my intention to duplicate your work. | 
| No worries-this was mostly for my own sake. If you have better coverage you have better coverage. | 
| closing in favor of #289 | 
This should be enough to get dynamic dns working. I say should because I haven't tested it just yet.
As far as remaining types go, libdns provides CAA/MX/SRV/ServiceBinding/SvcParams, all of which require further parsing and may be best saved for later.