Call MPI_AllReduce instead of C-wrapper for the 1D-recvbuf #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
allreduce_4.f90 is test for this |
gxyd
approved these changes
Apr 2, 2025
src/mpi.f90
Outdated
| c_op = c_mpi_op_f2c(op) | ||
| c_comm = c_mpi_comm_f2c(comm) | ||
|
|
||
| local_ierr = c_mpi_allreduce_scalar(sendbuf_ptr, recvbuf_ptr, count, c_datatype, c_op, c_comm) |
There was a problem hiding this comment.
to avoid ambiguity, can we rename this to c_mpi_allreduce? (and similarly the call in MPI_Allreduce_scalar as well)
gxyd
reviewed
Apr 2, 2025
src/mpi.f90
Outdated
| ierror = local_ierr | ||
| else | ||
| if (local_ierr /= MPI_SUCCESS) then | ||
| print *, "MPI_Allreduce_scalar failed with error code: ", local_ierr |
There was a problem hiding this comment.
Also, we can rename this to MPI_Allreduce_1D_recv_proc maybe?
adit4443ya
force-pushed
the
allreduce_1d_recv
branch
from
51ea2b2 to
6cfbc3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.