Skip to content

Handle 1D arrays for MPI_Ssend and Add Test for MPI_WaitAll #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

adit4443ya
Copy link
Collaborator

No description provided.

@adit4443ya
Copy link
Collaborator Author

Lfortran is giving segfault while rest of the tests passes , will investigate later

@gxyd
Copy link
Collaborator

gxyd commented Apr 2, 2025

At the CI, even the job Run standalone tests with MPICH without custom MPI Wrappers (ubuntu-20.04) failed, which is odd. Atleast this job has nothing to do with LFortran.

I checked it locally on my macOS, and it passes with MPICH without custom MPI wrappers.

@gxyd
Copy link
Collaborator

gxyd commented Apr 2, 2025

Also, I checked it with LFortran as well, and waitall_1.f90 seems to work without any problem locally on macOS:

> ./run_tests.sh waitall_1.f90
#################################
Using FC=/Users/gxyd/miniforge3/envs/pot3d_build/bin/lfortran compiler
Using CC=clang compiler
################################

Received argument(s). Will only compile/run: waitall_1.f90
Compiling waitall_1...
Running waitall_1 with 1 MPI ranks...
This test requires at least 2 MPI processes.
Test waitall_1 with 1 MPI ranks PASSED!
Running waitall_1 with 2 MPI ranks...
Rank 1 received buf1 =    1.00000000000000000e+00    2.00000000000000000e+00    3.00000000000000000e+00    4.00000000000000000e+00    5.00000000000000000e+00    6.00000000000000000e+00    7.00000000000000000e+00    8.00000000000000000e+00    9.00000000000000000e+00
Rank 1 received buf2 =    1.00000000000000000e+00    2.00000000000000000e+00    3.00000000000000000e+00    4.00000000000000000e+00    5.00000000000000000e+00    6.00000000000000000e+00    7.00000000000000000e+00    8.00000000000000000e+00    9.00000000000000000e+00
Rank 0 sent two messages.
Test waitall_1 with 2 MPI ranks PASSED!
Running waitall_1 with 4 MPI ranks...
Rank 0 sent two messages.
Rank 1 received buf1 =    1.00000000000000000e+00    2.00000000000000000e+00    3.00000000000000000e+00    4.00000000000000000e+00    5.00000000000000000e+00    6.00000000000000000e+00    7.00000000000000000e+00    8.00000000000000000e+00    9.00000000000000000e+00
Rank 1 received buf2 =    1.00000000000000000e+00    2.00000000000000000e+00    3.00000000000000000e+00    4.00000000000000000e+00    5.00000000000000000e+00    6.00000000000000000e+00    7.00000000000000000e+00    8.00000000000000000e+00    9.00000000000000000e+00
Test waitall_1 with 4 MPI ranks PASSED!

... Running standalone tests took 4 seconds ...

> echo $?
0

@gxyd
Copy link
Collaborator

gxyd commented Apr 2, 2025

Even the tests that I added, fail #90

@adit4443ya adit4443ya marked this pull request as draft May 27, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants