Skip to content

run standalone tests without custom MPI wrappers with MPICH as well #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

gxyd
Copy link
Collaborator

@gxyd gxyd commented Apr 1, 2025

Description

Testing with just OpenMPI isn't enough, we'll need to make sure that the added test program work both with Open MPI and MPICH as well.

I've seen program (see e.g.; below), which don't work with one of them:

e.g.;

program cart_shift_1
    use mpi
    implicit none

    integer :: ierr, rank, size
    integer :: dims(2), comm_cart
    logical :: periods(2)
    integer :: rank_source, rank_dest
    integer :: coords(2)

    call MPI_INIT(ierr)
    call MPI_COMM_RANK(MPI_COMM_WORLD, rank, ierr)
    call MPI_COMM_SIZE(MPI_COMM_WORLD, size, ierr)

    dims(1) = 2          ! rows
    dims(2) = size/2     ! columns
    periods(1) = .false. ! non-periodic in x
    periods(2) = .false. ! non-periodic in y

    call MPI_CART_CREATE(MPI_COMM_WORLD, 2, dims, periods, .true., comm_cart, ierr)

    print *, "rank: ", rank
    if (comm_cart == MPI_COMM_NULL) then
        if (rank == 0) then
            print *, 'Error creating Cartesian communicator'
        endif
        call MPI_FINALIZE(ierr)
        stop
    end if

end program cart_shift_1

the above program doesn't work with Open MPI but works with MPICH on macOS.

@gxyd gxyd merged commit 759473d into main Apr 2, 2025
20 checks passed
@gxyd gxyd deleted the without_wrappers branch April 2, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant