Skip to content

remove C MPI wrapper function for MPI_Dims_create #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2025
Merged

remove C MPI wrapper function for MPI_Dims_create #59

merged 1 commit into from
Mar 31, 2025

Conversation

gxyd
Copy link
Collaborator

@gxyd gxyd commented Mar 31, 2025

No description provided.

@adit4443ya
Copy link
Collaborator

A test would be good !!

@gxyd
Copy link
Collaborator Author

gxyd commented Mar 31, 2025 •
edited
Loading

We do have a test for MPI_Dims_create in https://github.com/gxyd/c_mpi/blob/main/tests/cart_sub.f90#L45

@gxyd
Copy link
Collaborator Author

gxyd commented Mar 31, 2025

I'm merging this PR as the test is already there. Definitely we would need to have more tests for all the mpi subroutines.

@gxyd gxyd merged commit 28385ad into main Mar 31, 2025
16 checks passed
@adit4443ya
Copy link
Collaborator

We do have a test for MPI_Dims_create in https://github.com/gxyd/c_mpi/blob/main/tests/cart_sub.f90#L45

Ohh Yes i forgot!!

@gxyd gxyd deleted the rem_c_wrapper_dims_create branch May 7, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gxyd @adit4443ya