refactor: move MPI_Finalize C wrapper to pure Fortran #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is interesting, the run: https://github.com/gxyd/c_mpi/actions/runs/13945829170/job/39032692275?pr=26 failed with the error: +++ TEST=validation
+++ MPIEXEC=/Users/runner/micromamba/envs/c_mpi_gfortran_env/bin/mpiexec
+++ cp /Users/runner/work/c_mpi/c_mpi/tests/pot3d/testsuite/validation/input/br_input_tiny_bin.bin /Users/runner/work/c_mpi/c_mpi/tests/pot3d/testsuite/validation/input/pot3d.dat /Users/runner/work/c_mpi/c_mpi/tests/pot3d/testsuite/validation/run/
+++ cd /Users/runner/work/c_mpi/c_mpi/tests/pot3d/testsuite/validation/run
+++ echo 'Running POT3D with 1 MPI rank...'
+++ /Users/runner/micromamba/envs/c_mpi_gfortran_env/bin/mpiexec -np 1 /Users/runner/work/c_mpi/c_mpi/tests/pot3d/bin/pot3d
Running POT3D with 1 MPI rank...
./validate.sh: line 11: 2268 Abort trap: 6 ${MPIEXEC} -np 1 ${POT3D_HOME}/bin/pot3d > pot3d.log 2> pot3d.err
Error: Process completed with exit code 134.Though, locally I don't get any error (on macOS with GFortran's optimization enabled) |
|
Could there be a bug in the CI setup? Because, I'm accessing the same directory structure in different CI jobs. |
|
Let me try re-running the CI. |
|
Now all the CI checks pass. |
|
I guess CI setups are correct |
adit4443ya
approved these changes
Mar 20, 2025
|
Perfect. Thanks for the review @adit4443ya , I'll merge this then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards completing the issue: #21