Skip to content

Feat: Implement Wrappers of MPI_COMM_CREATE and MPI_GROUP_RANGE_INCL #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 29, 2025

Conversation

adit4443ya
Copy link
Collaborator

Towards #121

@adit4443ya adit4443ya requested a review from gxyd May 28, 2025 07:17
Copy link
Collaborator

@gxyd gxyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, but left some comments to be addressed.

@adit4443ya
Copy link
Collaborator Author

I will add changes tomorrow

@adit4443ya adit4443ya marked this pull request as draft May 28, 2025 18:35
@adit4443ya adit4443ya requested a review from gxyd May 29, 2025 05:41
@adit4443ya adit4443ya marked this pull request as ready for review May 29, 2025 05:42
@adit4443ya
Copy link
Collaborator Author

I addressed all comments with latest commit

Copy link
Collaborator

@gxyd gxyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gxyd
Copy link
Collaborator

gxyd commented May 29, 2025

Perfect, I'll merge it, thanks for addressing the comments @adit4443ya

@gxyd gxyd merged commit b0512bf into lfortran:main May 29, 2025
8 checks passed
@adit4443ya adit4443ya added the enhancement New feature or request label May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants