-
Notifications
You must be signed in to change notification settings - Fork 2
CI: test validation2 dataset at fortran_mpi's CI #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It passes all the tests, but we can't reduce |
br_photo_file='' | ||
ncghist=10 | ||
ncgmax=10000000 | ||
epscg=1.e-8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only point of difference between validation
testsuite (which has epscg=1.e-12
) and validation2
introduced in this PR.
On my macbook air M4 machine with 16GB RAM (10 cores), with MPICH
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what this is doing, but it doesn't seem to break anything either.
the only different between validation and validation2 dataset is it sets the value of the read variable `epscg` (located at `testsuite/validation/input/pot3d.dat`'s namelist in validation dataset is `1e-12`, while in validation2 dataset it is `1e-8`
We'll now test both with |
The tests pass, so I'm merging this. |
Description
the only different between validation and validation2 dataset is it sets the value of the read variable
epscg
(located attestsuite/validation/input/pot3d.dat
's namelistin validation dataset is
1e-12
, while in validation2 datasetit is
1e-8
This test set is being tested only with the possible purpose that the testsuite
validation2
runs faster thanvalidation
dataset with GFortran and LFortran compilers both.I'll first check whether all the CI tests pass with
validation2
or not, just like they currently pass withvalidation
dataset. Once it does pass the tests, I'll post the timings difference between runningvalidation2
vsvalidation
dataset.NOTE: this PR isn't intended to be merged at all currently.