fix(actions): allow bufnr to be 0 #1422
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: documentation mentions that
bufnr
can be 0 forget_hunks
, but 0 is truthy, so the current logic does not workSolution: properly check if the current buf should be used (same logic as
vim._resolve_bufnr
)I also took the liberty of updating the type annotations to be more precise.
There are two other instances where the same logic is being used, but for them, 0 is not documented as being the current buf (so I haven't updated them):
gitsigns.nvim/lua/gitsigns/attach.lua
Lines 413 to 431 in 1ee5c1f
gitsigns.nvim/lua/gitsigns/actions.lua
Lines 71 to 95 in 1ee5c1f