fix(blame): get gh blame info asynchronously #1411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterCardenas
force-pushed
the
run-gh-async
branch
from
f8a5e91 to
61585be
Compare
|
win width should also be updated. |
|
@nenahp yup just noticed that and fixed it |
|
Would it be better to show placeholder information whilst gh info is loaded? Then once it is loaded, only update the exact line in the buffer instead of a complete redraw. |
|
i could change it to only update the exact line yea, though i still will need to do the win width/height calculation. a consideration is that some lines won't have a associate github pr. wondering if it's ok to show |
|
Ok leave as is for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Showing information for GitHub is nice, but it shouldn't block the popup from showing up. This PR immediately shows the information from git (which is often cached) while updating the popup with the information from GitHub once we load it.
I'm not too sure if we want a loading indicator of some sort here. It would be nice, just not sure what it should look like.