fix: calculate staged color dynamically adjust based on background #1244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where staged colors appeared too dark and hard to distinguish on light backgrounds. The previous algorithm did not properly account for different background themes, leading to poor contrast.
With this fix, staged colors now dynamically adapt based on whether the background is light or dark, ensuring better visibility and contrast in both themes.
Before
In the screenshot above, staged colors in the light color scheme are getting too dark to be able to tell apart.
After
After this fix is applied, staged colors now get lighter on a light color scheme, and vice versa.