fix: modify _get_base_url to use self-hosted mode when token is not set.
#6
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carenthomas
reviewed
Jan 7, 2025
Comment on lines
+161
to
164
| elif token is None: | ||
| return LettaEnvironment.SELF_HOSTED.value | ||
| elif environment is not None: | ||
| return environment.value |
There was a problem hiding this comment.
curious why this is before the environment check - if user specifies environment=LettaCloud but forgets to pass in token, would it be unexpected for it to use self_hosted rather than error?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
_get_base_url()method to accept the optional token parameter in determining which base_url to return.In the missing token case, the client will use the self-hosted url instead.